Conversation
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/feat/core-qol \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVED/main/ct/debian.sh)"Swap Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/feat/core-qol/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/ProxmoxVED/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/feat/core-qolNote that Useful flags while testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
Four independent fixes, one per function. None changes an existing call site.
msg_block_resume / msg_info / msg_ok (core/core.func)
msg_info pushes onto a block stack, msg_ok pops and restarts the spinner for whatever is underneath. A helper that opens its own block — setup_uv, setup_nodejs, fetch_and_deploy* — used to stop the outer block's spinner with nothing bringing it back, so the outer msg_ok reported on a step that had been invisible since. msg_warn/msg_error clear the stack, as they already killed the spinner. A msg_ok without a matching msg_info does not underflow.
random_password [length] (core/core.func)
Alphanumeric, exact length, default 24. Replaces openssl rand -base64 N | tr -dc … | head -c N, which returns fewer characters than asked for because the filter runs after the length is fixed, and takes a SIGPIPE under pipefail. Base64 also carries / and +, which break the DSN and URL strings these values get pasted into. Hex tokens are unaffected and stay as they are.
_cs_clean_target_dir (lib/forge.func)
New CLEAN_INSTALL_KEEP: space-separated paths relative to the target that survive a CLEAN_INSTALL=1 wipe. Moved aside and back rather than pruned from find — a kept path can be nested, and removing its parent would take it along; mv also keeps a symlink a symlink, which is the case that prompted this. Behaviour with the variable unset is unchanged.
_cs_write_cargo_net, setup_uv, setup_composer (lib/runtime.func)
Network limits for the remaining package managers, matching what pnpm and yarn already got: cargo [net] retry = 5 (appended, an existing config survives), UV_HTTP_TIMEOUT=600 (uv has no config key, only the env var), composer process-timeout 600 on both install paths.
🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
API.txtwas updated to match.🤖 AI Assistance (X in brackets)
🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.